Skip to content

fix: intercept self hold payments based on invoice rather than payment hash#2027

Open
rolznz wants to merge 3 commits intomasterfrom
fix/self-payments-wrapped-invoice
Open

fix: intercept self hold payments based on invoice rather than payment hash#2027
rolznz wants to merge 3 commits intomasterfrom
fix/self-payments-wrapped-invoice

Conversation

@rolznz
Copy link
Contributor

@rolznz rolznz commented Jan 31, 2026 •
edited
Loading

This PR also fixes a bug where we will fail saying the invoice has already been paid (I think would block wrapped invoices working with LND right now)

TODOs

  • undo expiry hack and regenerate invoices
  • test in sandbox locally (both wrapped and normal HOLD invoices)
  • test with LND (Polar - tested with JS SDK: chore: add example for wrapped invoices js-sdk#529)
  • test standard HOLD invoices with LDK (Mutinynet) NOTE: wrapped invoices are not supported yet by LDK-Node.
  • test keysend self-payments

Follow ups - move to new issue:

@rolznz rolznz added this to the v1.22.0 milestone Jan 31, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 31, 2026 •
edited
Loading

Warning

Rate limit exceeded

@rolznz has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 26 minutes and 57 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/self-payments-wrapped-invoice

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rolznz rolznz mentioned this pull request Feb 2, 2026
Merged
6 tasks
@rolznz rolznz modified the milestones: v1.22.0, v1.21.5 Feb 10, 2026
@rolznz rolznz self-assigned this Feb 10, 2026
@rolznz
Copy link
Contributor Author

rolznz commented Feb 13, 2026

@im-adithya @frnandu in the latest version of Polar (LND v20) payments were failing until I set a timeout seconds (which should have been set anyway. I set it to 50s)

@rolznz rolznz requested review from frnandu and im-adithya February 13, 2026 10:02
@rolznz rolznz marked this pull request as ready for review February 13, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@im-adithya im-adithya Awaiting requested review from im-adithya

@frnandu frnandu Awaiting requested review from frnandu

At least 1 approving review is required to merge this pull request.

Assignees

@rolznz rolznz

Labels

None yet

Projects

None yet

Milestone

v1.21.5

Development

Successfully merging this pull request may close these issues.

1 participant

@rolznz

Comments